Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 1908042: code review 1908042: update proto library prior to avoid New* methods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by r
Modified:
15 years ago
Reviewers:
dsymonds
CC:
rsc, dsymonds2
Visibility:
Public.

Description

update proto library prior to avoid New* methods. diffs generated automatically from Google-internal copy. all tests pass

Patch Set 1 #

Patch Set 2 : code review 1908042: update proto library prior to avoid New* methods. #

Patch Set 3 : code review 1908042: update proto library prior to avoid New* methods. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -112 lines) Patch
M README View 2 chunks +1 line, -3 lines 1 comment Download
M compiler/generator/generator.go View 1 chunk +1 line, -6 lines 0 comments Download
M compiler/testdata/extension_test.go View 6 chunks +6 lines, -6 lines 0 comments Download
M compiler/testdata/main.go View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/testdata/test.pb.go.golden View 4 chunks +0 lines, -12 lines 0 comments Download
M proto/all_test.go View 9 chunks +55 lines, -33 lines 0 comments Download
M proto/decode.go View 2 chunks +33 lines, -10 lines 0 comments Download
M proto/encode.go View 1 chunk +3 lines, -1 line 0 comments Download
M proto/testdata/test.pb.go View 13 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: dsymonds), I'd like you to review this change.
15 years ago (2010-07-28 21:43:27 UTC) #1
r
Hello rsc (cc: dsymonds), Please take another look.
15 years ago (2010-07-28 22:01:16 UTC) #2
dsymonds
LGTM Sigh. I had most of these changes done already, but couldn't hg upload or ...
15 years ago (2010-07-28 22:28:59 UTC) #3
r
*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=902511a92633 *** update proto library prior to avoid New* methods. diffs generated ...
15 years ago (2010-07-28 22:34:35 UTC) #4
dsymonds
15 years ago (2010-07-28 22:39:15 UTC) #5
FYI

http://codereview.appspot.com/1908042/diff/8001/9001
File README (right):

http://codereview.appspot.com/1908042/diff/8001/9001#newcode152
README:152: newTest := &example.Test()
Either I overlooked this, or it was a late addition. This should be
new(example.Test) or &example.Test{}.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b