Issue 1904045: code review 1904045: os: change the type of permissions argument for Open et...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1904045: code review 1904045: os: change the type of permissions argument for Open et... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by r

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

os: change the type of permissions argument for Open etc. to uint32. Besides being more correct, it protects against people accidentally exchanging the permission and open mode arguments to Open.

Patch Set 1 #

Patch Set 2 : code review 1904045: os: change the type of permissions argument for Open et... #

Patch Set 3 : code review 1904045: os: change the type of permissions argument for Open et... #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -128 lines)			Patch
M	doc/progs/file.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/goyacc/goyacc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/hgpatch/main.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/file.go	View	1	4 chunks	+16 lines, -16 lines	0 comments	Download
M	src/pkg/os/file_unix.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/file_windows.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/os/path.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_darwin.go	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/syscall_freebsd.go	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View		3 chunks	+15 lines, -15 lines	0 comments	Download
M	src/pkg/syscall/syscall_nacl.go	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_386.go	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_darwin_amd64.go	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_386.go	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_freebsd_amd64.go	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_386.go	View		7 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View		7 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View		7 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_nacl_386.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-08-03 21:48:40 UTC) #1

14 years, 9 months ago (2010-08-03 22:34:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5834fd4c7499 ***

os: change the type of permissions argument for Open etc. to uint32.
Besides being more correct, it protects against people accidentally
exchanging the permission and open mode arguments to Open.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1904045

Expand All Messages | Collapse All Messages