Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 1901042: Add user-init option to include a custom init snippet (not replacing the whole init file) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Reinhold
Modified:
13 years, 8 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add user-init option to include a custom init snippet (not replacing the whole init file) This allows the user to apply the same set of options/definitions to different files. In particular, lilypond -duser-include=myinclude.ily file.ly will compile file.ly, but read and execut myinclude.ily before file.ly is processed. That way, e.g. global paper changes can be easily done, and a file can be run several times, each time with a different user-include file containing different settings. This feature is similar to the --init=DATEI feature, except that --init will replace the whole init sequence (thus your init file will copy all of lilypond's init.ly), while -duser-include will only add some definitions to the normal init sequence in init.ly (i.e. the file is included using scheme in init.ly).

Patch Set 1 #

Patch Set 2 : Remove debug statement #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ly/init.ly View 1 1 chunk +7 lines, -0 lines 5 comments Download
M scm/lily.scm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Neil Puttock
http://codereview.appspot.com/1901042/diff/2001/3001 File ly/init.ly (right): http://codereview.appspot.com/1901042/diff/2001/3001#newcode26 ly/init.ly:26: #(if (ly:get-option 'user-init) user-include ? http://codereview.appspot.com/1901042/diff/2001/3001#newcode27 ly/init.ly:27: (begin remove ...
13 years, 9 months ago (2010-07-27 20:16:58 UTC) #1
Reinhold
http://codereview.appspot.com/1901042/diff/2001/3001 File ly/init.ly (right): http://codereview.appspot.com/1901042/diff/2001/3001#newcode26 ly/init.ly:26: #(if (ly:get-option 'user-init) On 2010/07/27 20:16:58, Neil Puttock wrote: ...
13 years, 9 months ago (2010-07-28 00:43:07 UTC) #2
Graham Percival
On Wed, Jul 28, 2010 at 12:43:08AM +0000, reinhold.kainhofer@gmail.com wrote: > On 2010/07/27 20:16:58, Neil ...
13 years, 8 months ago (2010-07-28 00:57:27 UTC) #3
Ian Hulin
Hi Reinhold, On 28/07/10 01:43, reinhold.kainhofer@gmail.com wrote: > Reviewers: Neil Puttock, > > > http://codereview.appspot.com/1901042/diff/2001/3001 ...
13 years, 8 months ago (2010-07-28 10:49:51 UTC) #4
c_sorensen
On 7/28/10 4:49 AM, "Ian Hulin" <ian@hulin.org.uk> wrote: > Hi Reinhold, > On 28/07/10 01:43, ...
13 years, 8 months ago (2010-07-28 14:09:54 UTC) #5
Reinhold
13 years, 8 months ago (2010-08-22 14:04:59 UTC) #6
On 2010/07/28 14:09:54, c_sorensen_byu.edu wrote:
> >> On 2010/07/27 20:16:58, Neil Puttock wrote:
> >>> user-include ?
> >> How about custom-definitions or user-definitions (no, sounds too much
> >> like it defines users)?
> > How about --user-startup or --custom-startup?
> How about --extra-init, or --include-init ?

I now changed the option name to -dinclude-settings, which describes it best
IMO. I have also pushed this to master.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b