code review 190104: gc: do not build builtin.c automatically; use golden co...

gc: do not build builtin.c automatically; use golden copy instead.

[rsc, 2010-01-21 23:41:42]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-21 23:43:38]

revised to remove the reference to p4 too.

[r, 2010-01-21 23:52:07]

http://codereview.appspot.com/190104/diff/1009/4
File src/cmd/gc/Makefile (right):

http://codereview.appspot.com/190104/diff/1009/4#newcode57
src/cmd/gc/Makefile:57: builtin.c: builtin.c.boot
i feel a comment is needed saying when to run mkbuiltin
you're now making it a user-done thing instead of automating it and that sounds
like a subtle point in an already subtle process

http://codereview.appspot.com/190104/diff/1009/5
File src/cmd/gc/mkbuiltin (right):

http://codereview.appspot.com/190104/diff/1009/5#newcode26
src/cmd/gc/mkbuiltin:26: if ! cmp _builtin.c builtin.c.boot >/dev/null
2>/dev/null
cmp -s is all you need. can drop the > and 2>

[rsc, 2010-01-22 22:28:38]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-01-22 23:16:03]

> i feel a comment is needed saying when to run mkbuiltin
> you're now making it a user-done thing instead of automating it and that
> sounds like a subtle point in an already subtle process

done, in unsafe.go and runtime.go and mkbuiltin.
i think having to run this by hand should make the
process much less subtle for users.  the fact that
i can't change the export format without breaking
everyone's build externally was one of the subtle
effects of the automation.

russ

[r, 2010-01-23 00:56:47]

LGTM

[rsc, 2010-01-23 00:58:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=b7a8762efcbe ***

gc: do not build builtin.c automatically; use golden copy instead.

R=r
CC=golang-dev
http://codereview.appspot.com/190104

Committer: Russ Cox <rsc@golang.org>