Issue 190044: code review 190044: codereview: accommodate recent change to ui.prompt

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 190044: code review 190044: codereview: accommodate recent change to ui.prompt (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by rsc

Modified:
15 years, 5 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

codereview: accommodate recent change to ui.prompt Fixes issue 525.

Patch Set 1 #

Patch Set 2 : code review 190044: codereview: accommodate recent change to ui.prompt #

Patch Set 3 : code review 190044: codereview: accommodate recent change to ui.prompt #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	lib/codereview/codereview.py	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 5 months ago (2010-01-19 02:25:52 UTC) #1

LGTM On Jan 19, 2010, at 1:25 PM, rsc@golang.org wrote: > Reviewers: r, > > ...

15 years, 5 months ago (2010-01-19 02:51:47 UTC) #2

LGTM

On Jan 19, 2010, at 1:25 PM, rsc@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> codereview: accommodate recent change to ui.prompt
>
> Fixes issue 525.
>
> Please review this at http://codereview.appspot.com/190044/show
>
> Affected files:
>  M lib/codereview/codereview.py
>
>
> Index: lib/codereview/codereview.py
> ===================================================================
> --- a/lib/codereview/codereview.py
> +++ b/lib/codereview/codereview.py
> @@ -77,6 +77,15 @@
> 		msg += linuxMessage
> 	raise util.Abort(msg)
>
> +def promptyesno(ui, msg):
> +	# Arguments to ui.prompt changed between 1.3 and 1.3.1.
> +	# Even so, some 1.3.1 distributions seem to have the old prompt!?!?
> +	# What a terrible way to maintain software.
> +	try:
> +		return ui.promptchoice(msg, ["&yes", "&no"], 0) == 0
> +	except AttributeError:
> +		return ui.prompt(msg, ["&yes", "&no"], "y") != "n"
> +
> # To experiment with Mercurial in the python interpreter:
> #    >>> repo = hg.repository(ui.ui(), path = ".")
>
> @@ -590,7 +599,7 @@
> 		s = ui.edit(s, ui.username())
> 		clx, line, err = ParseCL(s, cl.name)
> 		if err != '':
> -			if ui.prompt("error parsing change list: line %d: %s\nre-edit (y/ 
> n)?" % (line, err), ["&yes", "&no"], "y") == "n":
> +			if not promptyesno(ui, "error parsing change list: line %d: %s 
> \nre-edit (y/n)?" % (line, err)):
> 				return "change list not modified"
> 			continue
> 		cl.desc = clx.desc;
> @@ -598,7 +607,7 @@
> 		cl.cc = clx.cc
> 		cl.files = clx.files
> 		if cl.desc == '':
> -			if ui.prompt("change list should have description\nre-edit (y/ 
> n)?", ["&yes", "&no"], "y") != "n":
> +			if promptyesno(ui, "change list should have description\nre-edit  
> (y/n)?"):
> 				continue
> 		break
> 	return ""
>
>

rsc

15 years, 5 months ago (2010-01-20 17:49:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=181eb68763ef ***

codereview: accommodate recent change to ui.prompt

Fixes issue 525.

R=r
CC=golang-dev
http://codereview.appspot.com/190044

Expand All Messages | Collapse All Messages