Issue 1897043: code review 1897043: gofmt/go/parser: strengthen syntax checks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1897043: code review 1897043: gofmt/go/parser: strengthen syntax checks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by gri

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gofmt/go/parser: strengthen syntax checks - don't allow parenthesized receiver base types or anonymous fields - fixed a couple of other omissions - adjusted gofmt test script - removed several TODOs

Patch Set 1 #

Patch Set 2 : code review 1897043: gofmt/go/parser: strengthen syntax checks #

Patch Set 3 : code review 1897043: gofmt/go/parser: strengthen syntax checks #

Patch Set 4 : code review 1897043: gofmt/go/parser: strengthen syntax checks #

Patch Set 5 : code review 1897043: gofmt/go/parser: strengthen syntax checks #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -63 lines)			Patch
	M	src/cmd/gofmt/test.sh	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/go/parser/parser.go	View	1 2 3	16 chunks	+66 lines, -62 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-07-29 00:35:36 UTC) #1

gri

14 years, 11 months ago (2010-08-05 00:21:05 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=63f4087c0859 ***

gofmt/go/parser: strengthen syntax checks

- don't allow parenthesized receiver base types or anonymous fields
- fixed a couple of other omissions
- adjusted gofmt test script
- removed several TODOs

R=rsc
CC=golang-dev
http://codereview.appspot.com/1897043

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages