Issue 1892050: code review 1892050: test/peano: use directly recursive type def

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1892050: code review 1892050: test/peano: use directly recursive type def (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by gri

Modified:
14 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

test/peano: use directly recursive type def Test case for http://code.google.com/p/go/issues/detail?id=999

Patch Set 1 #

Patch Set 2 : code review 1892050: test/peano: use directly recursive type def #

Patch Set 3 : code review 1892050: test/peano: use directly recursive type def #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	test/peano.go	View	1 2	4 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-08-06 02:47:43 UTC) #1

rsc1

On Thu, Aug 5, 2010 at 19:51, <r@golang.org> wrote: > LGTM but maybe hold off ...

14 years, 8 months ago (2010-08-06 18:51:13 UTC) #3

gri

14 years, 8 months ago (2010-08-06 22:08:00 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=82922c533be1 ***

test/peano: use directly recursive type def

Test case for http://code.google.com/p/go/issues/detail?id=999

R=r
CC=golang-dev
http://codereview.appspot.com/1892050

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages