code review 189096: give bufio.Writer.WriteString the same signature as

give bufio.Writer.WriteString the same signature as
bytes.Buffer.WriteString

Fixes issue 535.

[r, 2010-01-16 00:11:53]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-16 02:03:30]

LGTM

but remove gob/Makefile from the CL

On Fri, Jan 15, 2010 at 16:11,  <r@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> give bufio.Writer.WriteString the same signature as
> bytes.Buffer.WriteString
>
> Fixes issue 535.
>
> Please review this at http://codereview.appspot.com/189096
>
> Affected files:
>  M src/pkg/bufio/bufio.go
>  M src/pkg/gob/Makefile
>
>
> Index: src/pkg/bufio/bufio.go
> ===================================================================
> --- a/src/pkg/bufio/bufio.go
> +++ b/src/pkg/bufio/bufio.go
> @@ -387,7 +387,7 @@
>
>  // Write writes the contents of p into the buffer.
>  // It returns the number of bytes written.
> -// If nn < len(p), also returns an error explaining
> +// If nn < len(p), it also returns an error explaining
>  // why the write is short.
>  func (b *Writer) Write(p []byte) (nn int, err os.Error) {
>        if b.err != nil {
> @@ -438,9 +438,12 @@
>  }
>
>  // WriteString writes a string.
> -func (b *Writer) WriteString(s string) os.Error {
> +// It returns the number of bytes written.
> +// If the count is less than len(s), it also returns an error explaining
> +// why the write is short.
> +func (b *Writer) WriteString(s string) (int, os.Error) {
>        if b.err != nil {
> -               return b.err
> +               return 0, b.err
>        }
>        // Common case, worth making fast.
>        if b.Available() >= len(s) || len(b.buf) >= len(s) && b.Flush() ==
> nil {
> @@ -448,12 +451,15 @@
>                        b.buf[b.n] = s[i]
>                        b.n++
>                }
> -               return nil
> +               return len(s), nil
>        }
>        for i := 0; i < len(s); i++ { // loop over bytes, not runes.
>                b.WriteByte(s[i])
> +               if b.err != nil {
> +                       return i, b.err
> +               }
>        }
> -       return b.err
> +       return len(s), nil
>  }
>
>  // buffered input and output
> Index: src/pkg/gob/Makefile
> ===================================================================
> --- a/src/pkg/gob/Makefile
> +++ b/src/pkg/gob/Makefile
> @@ -9,6 +9,7 @@
>        decode.go\
>        decoder.go\
>        encode.go\
> +       debug.go\
>        encoder.go\
>        type.go\
>
>
>
>

[r, 2010-01-16 02:06:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=63017ede3cdb ***

give bufio.Writer.WriteString the same signature as
bytes.Buffer.WriteString

Fixes issue 535.

R=rsc
CC=golang-dev
http://codereview.appspot.com/189096