Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 1885042: Fix default EL functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by chirag
Modified:
15 years, 3 months ago
Reviewers:
Paul Lindner, shindig.remailer, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This change prefixes all functions in the OpenSocial-Templating spec [1] with "os:". All other functions are prefixed with "osx:" Implemented os:htmlEncode and os:htmlDecode. [1] - http://opensocial-resources.googlecode.com/svn/spec/1.0/OpenSocial-Templating.xml#rfc.section.7.3

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
java/common/src/main/java/org/apache/shindig/expressions/OpensocialFunctions.java View 1 5 chunks +31 lines, -3 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/expressions/OpensocialFunctionsTest.java View 3 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 4
chirag
15 years, 5 months ago (2010-07-29 18:21:42 UTC) #1
chirag
15 years, 5 months ago (2010-07-29 18:23:42 UTC) #2
chirag
Doesn't look like the code review was dispatched by dev-remailer@shindig.apache.org. Resending to dev@shindig.apache.org Thanks, Chirag ...
15 years, 5 months ago (2010-07-29 21:41:59 UTC) #3
Paul Lindner
15 years, 5 months ago (2010-08-03 06:57:09 UTC) #4
seems fine, however I wonder if we want to support osx/os namespace for
compatibility?

Anyone using osx:* tags in production?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b