Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 1882046: code review 1882046: fmt.Scan: empty strings are errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by r
Modified:
14 years, 12 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

fmt.Scan: empty strings are errors Fixes issue 1002.

Patch Set 1 #

Patch Set 2 : code review 1882046: fmt.Scan: empty strings are errors #

Patch Set 3 : code review 1882046: fmt.Scan: empty strings are errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M src/pkg/fmt/scan.go View 1 1 chunk +10 lines, -4 lines 0 comments Download
M src/pkg/fmt/scan_test.go View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 12 months ago (2010-08-06 23:47:21 UTC) #1
rsc
Is an empty quoted string really an error? I understand having nothing `` being an ...
14 years, 12 months ago (2010-08-06 23:52:34 UTC) #2
rsc1
LGTM
14 years, 12 months ago (2010-08-06 23:56:32 UTC) #3
r
14 years, 12 months ago (2010-08-07 00:02:09 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=048ebbf32503 ***

fmt.Scan: empty strings are errors
Fixes issue 1002.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1882046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b