Hi Mike, LGTM apart from a few minor nitpicks, but I wonder whether it would ...
14 years, 8 months ago
(2010-08-02 23:10:49 UTC)
#1
Hi Mike,
LGTM apart from a few minor nitpicks, but I wonder whether it would be better to
export chain_callback () instead: this would provide a more generic way of
chaining offset callbacks.
Cheers,
Neil
http://codereview.appspot.com/1880050/diff/1/2
File lily/side-position-interface-scheme.cc (right):
http://codereview.appspot.com/1880050/diff/1/2#newcode23
lily/side-position-interface-scheme.cc:23: LY_DEFINE
(ly_side_position_interface__set_axis, "ly:side-position-interface::set-axis!",
ly_side_position_interface__set_axis_x
http://codereview.appspot.com/1880050/diff/1/2#newcode27
lily/side-position-interface-scheme.cc:27: LY_ASSERT_TYPE (unsmob_grob, grob,
1);
LY_ASSERT_SMOB (Grob, grob, 1);
I created a binding for chain_callback in grob-scheme.cc. Please see http://codereview.appspot.com/1890044 . I'm fine using ...
14 years, 8 months ago
(2010-08-03 09:57:27 UTC)
#2
I created a binding for chain_callback in grob-scheme.cc. Please see
http://codereview.appspot.com/1890044 . I'm fine using this and then maybe
making a scheme version of set_axis (i.e. side-position-interface::set-axis) in
the appropriate .scm file. First, let me know if this is what you had in mind.
Cheers,
Mike
On 2010/08/03 09:57:27, MikeSol wrote: > I created a binding for chain_callback in grob-scheme.cc. Please ...
14 years, 8 months ago
(2010-08-04 18:42:36 UTC)
#3
On 2010/08/03 09:57:27, MikeSol wrote:
> I created a binding for chain_callback in grob-scheme.cc. Please see
> http://codereview.appspot.com/1890044 . I'm fine using this and then maybe
> making a scheme version of set_axis (i.e. side-position-interface::set-axis)
in
> the appropriate .scm file. First, let me know if this is what you had in
mind.
That's exactly what I was thinking.
Once we're using Guile 2.0 we might even contemplate moving chain_callback to
scheme too (all it needs is a slight tweak to property checking and a binding
for simple_closure_expression).
Cheers,
Neil
Issue 1880050: Adds scheme binding for Side_position_interface::set_axis
(Closed)
Created 14 years, 8 months ago by MikeSol
Modified 13 years, 9 months ago
Reviewers: Neil Puttock
Base URL:
Comments: 2