Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13727)

Issue 1880050: Adds scheme binding for Side_position_interface::set_axis (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by MikeSol
Modified:
12 years, 9 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds scheme binding for Side_position_interface::set_axis Provides scheme bindings for Side_position_interface::set_axis

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
A lily/side-position-interface-scheme.cc View 1 chunk +35 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Neil Puttock
Hi Mike, LGTM apart from a few minor nitpicks, but I wonder whether it would ...
13 years, 8 months ago (2010-08-02 23:10:49 UTC) #1
MikeSol
I created a binding for chain_callback in grob-scheme.cc. Please see http://codereview.appspot.com/1890044 . I'm fine using ...
13 years, 8 months ago (2010-08-03 09:57:27 UTC) #2
Neil Puttock
13 years, 8 months ago (2010-08-04 18:42:36 UTC) #3
On 2010/08/03 09:57:27, MikeSol wrote:
> I created a binding for chain_callback in grob-scheme.cc.  Please see
> http://codereview.appspot.com/1890044 .  I'm fine using this and then maybe
> making a scheme version of set_axis (i.e. side-position-interface::set-axis)
in
> the appropriate .scm file.  First, let me know if this is what you had in
mind.

That's exactly what I was thinking.

Once we're using Guile 2.0 we might even contemplate moving chain_callback to
scheme too (all it needs is a slight tweak to property checking and a binding
for simple_closure_expression).

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b