Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 1875049: code review 1875049: godoc: accept '!' as end of first sentence of package d... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by gri
Modified:
14 years, 11 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godoc: accept '.', '!', and '?' as end of first sentence of package documentation

Patch Set 1 #

Patch Set 2 : code review 1875049: godoc: accept '!' as end of first sentence of package d... #

Patch Set 3 : code review 1875049: godoc: accept '.', '!', and '?' as end of first sentenc... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/cmd/godoc/godoc.go View 1 2 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-07-26 22:42:55 UTC) #1
r2
LGTM while you're there, might as well accept '?' -rob
14 years, 11 months ago (2010-07-26 22:44:46 UTC) #2
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=327a4d90e20c *** godoc: accept '.', '!', and '?' as end of first ...
14 years, 11 months ago (2010-07-27 00:34:42 UTC) #3
rsc
LGTM what was the example?
14 years, 11 months ago (2010-07-27 00:36:30 UTC) #4
gri
14 years, 11 months ago (2010-07-27 00:39:53 UTC) #5
http://r45:6060/pkg/exp/spacewar/

(Rob suggested to simply complete the list by adding '?')
- gri

On Mon, Jul 26, 2010 at 5:36 PM, Russ Cox <rsc@golang.org> wrote:

> LGTM
>
> what was the example?
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b