Issue 1867042: code review 1867042: gc: various bug fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1867042: code review 1867042: gc: various bug fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
14 years, 12 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

gc: various bug fixes Fixes issue 935. Fixes issue 936. Fixes issue 941.

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -17 lines)			Patch
M	src/cmd/gc/lex.c	View	14 chunks	+56 lines, -17 lines	0 comments	Download
M	src/cmd/gc/mparith1.c	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/cmd/gc/print.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 12 months ago (2010-07-21 06:45:32 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=59e3b20071af *** gc: various bug fixes Fixes issue 935. Fixes issue 936. ...

14 years, 12 months ago (2010-07-21 06:45:42 UTC) #2

LGTM