code review 1864042: Updated VIM syntax file to recognize integral constants...

Updated VIM syntax file to recognize integral constants of the
form 1e9 or -1e9.

[petar-m, 2010-07-21 17:22:48]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg1, 2010-07-22 07:25:34]

It doesn't highlight the minus or plus signs for me, but it never did
for normal decimals in the first place. Does it highlight them for
you? I'm running Vim 7.2.22.

On 22 July 2010 03:22,  <petarm@gmail.com> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> Updated VIM syntax file to recognize integral constants of the
> form 1e9 or -1e9.
>
> Please review this at http://codereview.appspot.com/1864042/show
>
> Affected files:
>  M misc/vim/syntax/go.vim
>
>
> Index: misc/vim/syntax/go.vim
> ===================================================================
> --- a/misc/vim/syntax/go.vim
> +++ b/misc/vim/syntax/go.vim
> @@ -137,6 +137,7 @@
>
>  " Integers
>  syn match       goDecimalInt        "\<\d\+\>"
> +syn match       goDecimalInt        "\<[-+]\?\d\+[Ee]\d\+\>"
>  syn match       goHexadecimalInt    "\<0x\x\+\>"
>  syn match       goOctalInt          "\<0\o\+\>"
>  syn match       goOctalError        "\<0\o*[89]\d*\>"
>
>
>

[rsc, 2010-07-22 14:56:15]

-5 is not a decimal int anyway.
it's a constant expression, like 3 + 4.

russ

[petar-m, 2010-07-22 19:30:04]

Fixed it. Uploaded.

--Petar


On Thu, Jul 22, 2010 at 10:56 AM, Russ Cox <rsc@golang.org> wrote:
> -5 is not a decimal int anyway.
> it's a constant expression, like 3 + 4.
>
> russ
>

[adg, 2010-07-23 01:33:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=eb7a39ace3d9 ***

misc/vim: updated syntax file to recognize constants of the form 1e9

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/1864042

Committer: Andrew Gerrand <adg@golang.org>