code review 1863046: test/sigchld.go: use syscall.Kill instead of a combination

test/sigchld.go: use syscall.Kill instead of a combination
of syscall.Syscall and syscall.SYS_KILL.

In RTEMS, there is no syscall.Syscall support, but it does
support POSIX signals. So, if this testcase is changed to use
syscall.Kill, then it would run fine on RTEMS, when using gccgo.

[Raj_, 2010-07-26 19:49:55]

Hello rsc, iant (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[Raj_, 2010-07-26 19:53:39]

On Tue, Jul 27, 2010 at 1:19 AM, <vinutheraj@gmail.com> wrote:

> Reviewers: rsc, iant,
>
> Message:
> Hello rsc, iant (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> test/sigchld.go: use syscall.Kill instead of a combination
> of syscall.Syscall and syscall.SYS_KILL.
>
>
From looking at the log of the commit message when this file was originally
committed, I see that the aim was to test the signal handling of the runtime
and not specifically to test syscall.Syscall, so I guess this change is ok
?

[rsc1, 2010-07-29 01:26:12]

LGTM

[rsc, 2010-07-29 01:26:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=43fd9bb529f0 ***

test/sigchld.go: use syscall.Kill instead of a combination
of syscall.Syscall and syscall.SYS_KILL.

In RTEMS, there is no syscall.Syscall support, but it does
support POSIX signals. So, if this testcase is changed to use
syscall.Kill, then it would run fine on RTEMS, when using gccgo.

R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1863046

Committer: Russ Cox <rsc@golang.org>

[Raj_, 2010-07-29 11:11:34]

Thanks.

On Thu, Jul 29, 2010 at 6:56 AM, <rsc@google.com> wrote:

> LGTM
>
>
>
> http://codereview.appspot.com/1863046/show
>