Issue 186255: code review 186255: Trim space on input to make searching more robust.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186255: code review 186255: Trim space on input to make searching more robust. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by cw

Modified:
15 years, 6 months ago

Reviewers:

CC:
rsc, r, gri, golang-dev

Visibility:
Public.

Description

Trim space on input to make searching more robust.

Patch Set 1 #

Patch Set 2 : code review 186255: Trim space on input to make searching more robust. #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/godoc/godoc.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc, r, gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 6 months ago (2010-01-21 06:27:21 UTC) #1

LGTM although the search text needs to be treated with more sophistication overall

15 years, 6 months ago (2010-01-22 03:25:56 UTC) #2

15 years, 6 months ago (2010-01-22 03:26:20 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=44dcf8018694 ***

Trim space on input to make searching more robust.

R=rsc, r, gri
CC=golang-dev
http://codereview.appspot.com/186255

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages