Inject __isgadget beacon to differentiate btw rendered gadget and type=url/generic IFRAME

@see http://issues.apache.org/jira/browse/SHINDIG-1267

[Paul Lindner, 2010-01-21 07:42:28]

http://codereview.appspot.com/186253/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
(right):

http://codereview.appspot.com/186253/diff/1/3#newcode166
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java:166:
injectGadgetBeacon(gadget, head);
could we avoid an extra script tag here and inject into the mainscripttag below?

[henry.saputra, 2010-01-21 19:36:41]

some small comment.

http://codereview.appspot.com/186253/diff/1/4
File features/src/main/javascript/features/rpc/rpc.js (right):

http://codereview.appspot.com/186253/diff/1/4#newcode618
features/src/main/javascript/features/rpc/rpc.js:618: if (window['__isgadget']
=== true) {
We could just check:
if(window['__isgadget']) {

which I think will check for both true and undefined

[johnfargo, 2010-01-21 23:27:21]

Sadly it can't (easily) -- the beacon needs to appear before feature libs,
which may be inlined or extern. Creating a new <script> tag avoids having to
deal w/ that conditional logic.

On Wed, Jan 20, 2010 at 11:42 PM, <lindner@inuus.com> wrote:

>
> http://codereview.appspot.com/186253/diff/1/3
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
> (right):
>
> http://codereview.appspot.com/186253/diff/1/3#newcode166
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java:166:
> injectGadgetBeacon(gadget, head);
> could we avoid an extra script tag here and inject into the
> mainscripttag below?
>
>
> http://codereview.appspot.com/186253/show
>

[johnfargo, 2010-01-21 23:28:34]

Hi Henry: thanks for the comment. It's true that we could drop the
"===true") but I prefer it this way to be as precise as possible about the
checked value (since we inject __isgadget=true verbatim).

Cheers,
John

On Thu, Jan 21, 2010 at 11:36 AM, <henry.saputra@gmail.com> wrote:

> some small comment.
>
>
> http://codereview.appspot.com/186253/diff/1/4
> File features/src/main/javascript/features/rpc/rpc.js (right):
>
> http://codereview.appspot.com/186253/diff/1/4#newcode618
> features/src/main/javascript/features/rpc/rpc.js:618: if
> (window['__isgadget'] === true) {
> We could just check:
> if(window['__isgadget']) {
>
> which I think will check for both true and undefined
>
>
> http://codereview.appspot.com/186253/show
>