code review 186143: runtime cleanup.

runtime cleanup.
  * move memory code into $GOOS-specific directory.
  * allow printing of static strings < 256 bytes.
    (dynamic strings will bump maxstring as they are allocated.)
  * use cgo2c for runtime.mal.

[rsc, 2010-01-14 00:05:47]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[dho, 2010-01-14 01:00:00]

LGTM; comments re: FreeBSD below

http://codereview.appspot.com/186143/diff/1037/15
File src/pkg/runtime/freebsd/mem.c (right):

http://codereview.appspot.com/186143/diff/1037/15#newcode13
src/pkg/runtime/freebsd/mem.c:13: if(p < (void*)4096) {
Why not just get MAP_FAILED from whatever defs.h is being used? At least in
FreeBSD:

#define MAP_FAILED	((void *)-1)

So I don't think this test will work (and it may be similar for Darwin)

[rsc, 2010-01-14 01:05:51]

> http://codereview.appspot.com/186143/diff/1037/15#newcode13
> src/pkg/runtime/freebsd/mem.c:13: if(p < (void*)4096) {
> Why not just get MAP_FAILED from whatever defs.h is being used? At least
> in FreeBSD:
>
> #define MAP_FAILED      ((void *)-1)
>
> So I don't think this test will work (and it may be similar for Darwin)

map_failed is defined by the c library,
not the system call interface, but you're
right that the code doesn't apply.
only the linux mmap can return an error.
i took the check out of freebsd.c and darwin.c.

russ

[r, 2010-01-14 01:49:25]

LGTM

[rsc, 2010-01-14 01:50:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=9aa35052893f ***

runtime cleanup.
  * move memory code into $GOOS-specific directory.
  * allow printing of static strings < 256 bytes.
    (dynamic strings will bump maxstring as they are allocated.)
  * use cgo2c for runtime.mal.

R=r, dho
CC=golang-dev
http://codereview.appspot.com/186143