Issue 186116: code review 186116: ignore $GOARCH inside the compiler and linker.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186116: code review 186116: ignore $GOARCH inside the compiler and linker. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by r

Modified:
15 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

ignore $GOARCH inside the compiler and linker. by definition, they know what they are building for. makes it easier to switch architectures when testing. % 6g x.go % 6l x.6 % 6.out "Wed Jan 13 10:57:46 EST 2010" % 8g x.go % 8l x.8 % 8.out "Wed Jan 13 10:57:46 EST 2010" % echo $GOARCH %

Patch Set 1 #

Patch Set 2 : code review 186116: ignore $GOARCH inside the compiler and linker. #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
M	src/cmd/gc/lex.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/lib.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 6 months ago (2010-01-13 02:46:58 UTC) #1

rsc

LGTM can drop the if(goarch == nil) in ld/lib.c and set goarch unconditionally.

15 years, 6 months ago (2010-01-13 03:18:40 UTC) #2

On Jan 13, 2010, at 2:18 PM, Russ Cox wrote: > LGTM > > can ...

15 years, 6 months ago (2010-01-13 03:38:30 UTC) #3

15 years, 6 months ago (2010-01-13 03:39:18 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=569595e235d8 ***

ignore $GOARCH inside the compiler and linker.
by definition, they know what they are building for.
makes it easier to switch architectures when testing.

% 6g x.go
% 6l x.6
% 6.out
"Wed Jan 13 10:57:46 EST 2010"
% 8g x.go
% 8l x.8
% 8.out
"Wed Jan 13 10:57:46 EST 2010"
% echo $GOARCH

%

R=rsc
CC=golang-dev
http://codereview.appspot.com/186116

Expand All Messages | Collapse All Messages