Issue 186073: code review 186073: Cgo: Handle C99 bool type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186073: code review 186073: Cgo: Handle C99 bool type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by dho

Modified:
15 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cgo: Handle C99 bool type Fixes issue 307

Patch Set 2 : code review 186073: Cgo: Handle C99 bool type #

Total comments: 1

Patch Set 3 : code review 186073: Cgo: Handle C99 bool type #

Patch Set 4 : code review 186073: Cgo: Handle C99 bool type #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/cmd/cgo/gcc.go	View	1 2	4 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dho

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 6 months ago (2010-01-11 21:12:54 UTC) #1

rsc

http://codereview.appspot.com/186073/diff/4/5 File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/186073/diff/4/5#newcode332 src/cmd/cgo/gcc.go:332: bool ast.Expr // denotes padding byte still denotes padding; ...

15 years, 6 months ago (2010-01-11 21:30:15 UTC) #2

dho

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 6 months ago (2010-01-11 21:31:19 UTC) #3

rsc

15 years, 6 months ago (2010-01-13 18:25:34 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=7d7f13d3a5c3 ***

cgo: handle C99 bool type

Fixes issue 307.

R=rsc
CC=golang-dev
http://codereview.appspot.com/186073

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages