Issue 186043: code review 186043: Partial work-around for gofmt bug.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186043: code review 186043: Partial work-around for gofmt bug. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by gri

Modified:
15 years, 6 months ago

Reviewers:

CC:
r, golang-dev, rsc

Visibility:
Public.

Description

Partial work-around for gofmt bug. Addresses some cases and respects position of closing parenthesis; but doesn't work yet in all cases. Heuristic; will need to be replaced by a real solution eventually. Does not cause existing code to be reformatted.

Patch Set 1 #

Patch Set 2 : code review 186043: Partial work-around for gofmt bug. #

Patch Set 3 : code review 186043: Partial work-around for gofmt bug. #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -26 lines)			Patch
M	src/pkg/go/printer/nodes.go	View		16 chunks	+26 lines, -22 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.golden	View	1 2	2 chunks	+27 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.input	View	1 2	2 chunks	+28 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.raw	View	1 2	2 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com, rsc), I'd like you to review this change.

15 years, 6 months ago (2010-01-09 01:09:28 UTC) #1

gri

15 years, 6 months ago (2010-01-11 18:38:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=59fa7bb32468 ***

Partial work-around for gofmt bug.

Addresses some cases and respects position of
closing parenthesis; but doesn't work yet in
all cases. Heuristic; will need to be replaced
by a real solution eventually. Does not cause
existing code to be reformatted.

R=r
CC=golang-dev, rsc
http://codereview.appspot.com/186043

Expand All Messages | Collapse All Messages