code review 1857048: builder: update script so it doesn't create tar-bombs

builder: update script so it doesn't create tar-bombs

[adg, 2010-08-02 02:57:55]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-08-02 04:12:27]

http://codereview.appspot.com/1857048/diff/1/2
File misc/dashboard/builder.sh (right):

http://codereview.appspot.com/1857048/diff/1/2#newcode83
misc/dashboard/builder.sh:83: # do a little dance
Worth explaining what's going on.

http://codereview.appspot.com/1857048/diff/1/2#newcode92
misc/dashboard/builder.sh:92: # cd go because we're expected to be ../.. away
from builder dir
This is kind of strange.  Easier would be to say do ( at top of loop and ) done
below so that the whole thing runs in a subshell.  Then the cd ../.. can go away
entirely.

http://codereview.appspot.com/1857048/diff/1/2#newcode97
misc/dashboard/builder.sh:97: exit
drop

[adg, 2010-08-02 04:21:46]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2010-08-02 04:22:17]

On 2 August 2010 14:12,  <rsc@google.com> wrote:
> http://codereview.appspot.com/1857048/diff/1/2
> File misc/dashboard/builder.sh (right):
>
> http://codereview.appspot.com/1857048/diff/1/2#newcode83
> misc/dashboard/builder.sh:83: # do a little dance
> Worth explaining what's going on.

Done.

> http://codereview.appspot.com/1857048/diff/1/2#newcode92
> misc/dashboard/builder.sh:92: # cd go because we're expected to be ../..
> away from builder dir
> This is kind of strange.  Easier would be to say do ( at top of loop and
> ) done below so that the whole thing runs in a subshell.  Then the cd
> ../.. can go away entirely.

Done.

> http://codereview.appspot.com/1857048/diff/1/2#newcode97
> misc/dashboard/builder.sh:97: exit
> drop

Whoops. An artefact of testing that somehow stayed in. Gone.

Andrew

[rsc1, 2010-08-03 01:05:15]

LGTM

[adg, 2010-08-03 01:06:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=e09dd2380ac1 ***

builder: update script so it doesn't create tar-bombs

R=rsc
CC=golang-dev
http://codereview.appspot.com/1857048