Issue 1856047: code review 1856047: net: change IPv6 address text representation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1856047: code review 1856047: net: change IPv6 address text representation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by mikio

Modified:
14 years, 12 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: change IPv6 address text representation draft-ietf-6man-text-addr-representation-07 will introduce a canonical textual representation format for IPv6 address.

Patch Set 1 #

Patch Set 2 : code review 1856047: net: change IPv6 address text representation #

Total comments: 2

Patch Set 3 : code review 1856047: net: change IPv6 address text representation #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	src/pkg/net/ip.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/pkg/net/ip_test.go	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-07-21 12:43:36 UTC) #1

rsc1

looks good; a few nits about the test. please fix and re-run hg mail thanks ...

15 years ago (2010-08-03 20:27:11 UTC) #2

mikio

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years ago (2010-08-04 14:29:59 UTC) #3

rsc1

This looks good. Could you please complete a CLA as described at http://golang.org/doc/contribute.html#copyright so that ...

15 years ago (2010-08-06 22:40:38 UTC) #4

mikio

On 2010/08/06 22:40:38, rsc1 wrote: > Could you please complete a CLA as described at ...

15 years ago (2010-08-07 19:58:44 UTC) #5

rsc

14 years, 12 months ago (2010-08-12 07:03:06 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=3361ef214bd6 ***

net: make IPv6 String method standards compliant

draft-ietf-6man-text-addr-representation-07 will introduce
a canonical textual representation format for IPv6 address.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1856047

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages