Issue 1853042: code review 1853042: re2 build tuning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1853042: code review 1853042: re2 build tuning (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by rsc

Modified:
15 years, 2 months ago

Reviewers:

CC:
r, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2 build tuning Shorten dfa_test, possible_match_test. Split reasonably sized tests from huge tests and run only the former by default. Shared library hell. GNU make variables. Fixes issue 20. Fixes issue 22. Fixes issue 25.

Patch Set 1 #

Patch Set 2 : code review 1853042: re2 build tuning #

Patch Set 3 : code review 1853042: re2 build tuning #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -46 lines)			Patch
M	Makefile	View	5 chunks	+52 lines, -12 lines	0 comments	Download
M	libre2.symbols	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	libre2.symbols.darwin	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	re2/testing/dfa_test.cc	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	re2/testing/possible_match_test.cc	View	1 chunk	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-07-16 05:37:00 UTC) #1

rsc

15 years, 2 months ago (2010-07-16 18:17:57 UTC) #3

*** Submitted as http://code.google.com/p/re2/source/detail?r=8b066f89c3b5 ***

re2 build tuning

Shorten dfa_test, possible_match_test.

Split reasonably sized tests from huge tests
and run only the former by default.

Shared library hell.

GNU make variables.

Fixes issue 20.
Fixes issue 22.
Fixes issue 25.

R=r
CC=re2-dev
http://codereview.appspot.com/1853042

Expand All Messages | Collapse All Messages