Issue 1849042: code review 1849042: play well with valgrind

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1849042: code review 1849042: play well with valgrind (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by rsc

Modified:
15 years, 8 months ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

play well with valgrind

Patch Set 1 #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4583 lines, -12 lines)			Patch
M	Makefile	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	util/sparse_array.h	View	2 chunks	+17 lines, -6 lines	0 comments	Download
M	util/sparse_set.h	View	2 chunks	+21 lines, -6 lines	0 comments	Download
M	util/util.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	util/valgrind.h	View	1 chunk	+4517 lines, -0 lines	0 comments	Download
A	util/valgrind.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years, 8 months ago (2010-07-16 02:08:32 UTC) #1

rsc

15 years, 8 months ago (2010-07-16 02:08:37 UTC) #2

*** Submitted as http://code.google.com/p/re2/source/detail?r=1739d0b10276 ***

play well with valgrind

R=rsc
CC=re2-dev
http://codereview.appspot.com/1849042

Expand All Messages | Collapse All Messages