LGTM
But we don't typically update the copyright headers on existing files.
On Wednesday, July 21, 2010, <micah.stetson@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> gotest: fix the glob pattern in the top-of-file comment
>
> Please review this at http://codereview.appspot.com/1847042/show
>
> Affected files:
> M src/cmd/gotest/gotest
>
>
> Index: src/cmd/gotest/gotest
> ===================================================================
> --- a/src/cmd/gotest/gotest
> +++ b/src/cmd/gotest/gotest
> @@ -1,12 +1,12 @@
> #!/usr/bin/env bash
> -# Copyright 2009 The Go Authors. All rights reserved.
> +# Copyright 2010 The Go Authors. All rights reserved.
> # Use of this source code is governed by a BSD-style
> # license that can be found in the LICENSE file.
>
> -# Using all the test*.go files in the current directory, write out a file
> +# Using all the *_test.go files in the current directory, write out a file
> # _testmain.go that runs all its tests. Compile everything and run the
> # tests.
> -# If files are named on the command line, use them instead of test*.go.
> +# If files are named on the command line, use them instead of *_test.go.
>
> # Makes egrep,grep work better in general if we put them
> # in ordinary C mode instead of what the current language is.
>
>
>
*** Submitted as http://code.google.com/p/go/source/detail?r=6d69c9da62ea *** gotest: fix the glob pattern in the top-of-file comment R=golang-dev, ...
Issue 1847042: code review 1847042: gotest: fix the glob pattern in the top-of-file comment
Created 15 years ago by mstetson
Modified 15 years ago
Reviewers:
Base URL:
Comments: 0