Issue 1843044: code review 1843044: gofmt: fix some linebreak issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1843044: code review 1843044: gofmt: fix some linebreak issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by gri

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gofmt: fix some linebreak issues - don't lose empty lines after labels - canonicalize number of line breaks - gofmt src misc, fixes a couple of irregular breaks

Patch Set 1 #

Patch Set 2 : code review 1843044: gofmt: fix some linebreak issues #

Patch Set 3 : code review 1843044: gofmt: fix some linebreak issues #

Patch Set 4 : code review 1843044: gofmt: fix some linebreak issues #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -48 lines)			Patch
M	src/pkg/compress/flate/huffman_code.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/compress/flate/inflate.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/go/doc/comment.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	15 chunks	+36 lines, -32 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	8 chunks	+31 lines, -11 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View		2 chunks	+48 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/statements.input	View		2 chunks	+53 lines, -0 lines	0 comments	Download
M	src/pkg/nntp/nntp_test.go	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-07-20 02:14:25 UTC) #1

gri

14 years, 9 months ago (2010-07-20 16:29:35 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=856fa94de87e ***

gofmt: fix some linebreak issues

- don't lose empty lines after labels
- canonicalize number of line breaks
- gofmt src misc, fixes a couple of irregular breaks

R=rsc
CC=golang-dev
http://codereview.appspot.com/1843044

Expand All Messages | Collapse All Messages