code review 184058: math: fix pow10 comment, test portable Sqrt

math: fix pow10 comment, test portable Sqrt

[rsc, 2010-01-10 23:50:30]

Hello r (cc: cldorian@gmail.com, golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-01-10 23:52:23]

LGTM

On 11/01/2010, at 10:50 AM, rsc@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: cldorian@gmail.com, golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> math: fix pow10 comment, test portable Sqrt
> 
> Please review this at http://codereview.appspot.com/184058
> 
> Affected files:
>  M src/pkg/math/all_test.go
>  M src/pkg/math/pow10.go
>  A src/pkg/math/sqrt_test.go
> 
> 
> Index: src/pkg/math/all_test.go
> ===================================================================
> --- a/src/pkg/math/all_test.go
> +++ b/src/pkg/math/all_test.go
> @@ -307,7 +307,6 @@
> 
> func TestAcos(t *testing.T) {
> 	for i := 0; i < len(vf); i++ {
> -		//		if f := Acos(vf[i] / 10); !veryclose(acos[i], f) {
> 		if f := Acos(vf[i] / 10); !close(acos[i], f) {
> 			t.Errorf("Acos(%g) = %g, want %g\n", vf[i]/10, f, acos[i])
> 		}
> @@ -405,8 +404,12 @@
> func TestSqrt(t *testing.T) {
> 	for i := 0; i < len(vf); i++ {
> 		a := Fabs(vf[i])
> -		if f := Sqrt(a); !veryclose(sqrt[i], f) {
> -			t.Errorf("Sqrt(%g) = %g, want %g\n", a, f, floor[i])
> +		if f := SqrtGo(a); sqrt[i] != f {
> +			t.Errorf("sqrtGo(%g) = %g, want %g\n", a, f, sqrt[i])
> +		}
> +		a = Fabs(vf[i])
> +		if f := Sqrt(a); sqrt[i] != f {
> +			t.Errorf("Sqrt(%g) = %g, want %g\n", a, f, sqrt[i])
> 		}
> 	}
> }
> @@ -430,7 +433,7 @@
> func TestHypot(t *testing.T) {
> 	for i := 0; i < len(vf); i++ {
> 		a := Fabs(tanh[i] * Sqrt(2))
> -		if f := Hypot(tanh[i], tanh[i]); !veryclose(a, f) {
> +		if f := Hypot(tanh[i], tanh[i]); a != f {
> 			t.Errorf("Hypot(%g, %g) = %g, want %g\n", tanh[i], tanh[i], f, a)
> 		}
> 	}
> Index: src/pkg/math/pow10.go
> ===================================================================
> --- a/src/pkg/math/pow10.go
> +++ b/src/pkg/math/pow10.go
> @@ -15,7 +15,7 @@
> 
> var pow10tab [70]float64
> 
> -// Pow10 returns 10**x, the base-10 exponential of x.
> +// Pow10 returns 10**e, the base-10 exponential of e.
> func Pow10(e int) float64 {
> 	if e < 0 {
> 		return 1 / Pow10(-e)
> Index: src/pkg/math/sqrt_test.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/src/pkg/math/sqrt_test.go
> @@ -0,0 +1,9 @@
> +// Copyright 2010 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package math
> +
> +// Make sqrtGo available for testing.
> +
> +func SqrtGo(x float64) float64 { return sqrtGo(x) }
> 
> 

[rsc, 2010-01-11 19:25:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=5a33d14b11b2 ***

math: fix pow10 comment, test portable Sqrt

R=r
CC= golang-dev, Charlie Dorian, golang-dev
http://codereview.appspot.com/184058