http://codereview.appspot.com/183130/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java (right): http://codereview.appspot.com/183130/diff/1/3#newcode144 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java:144: } catch (Exception e) { Another bug fix, not ...
14 years, 4 months ago
(2010-01-06 19:32:35 UTC)
#2
http://codereview.appspot.com/183130/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java
(right):
http://codereview.appspot.com/183130/diff/1/3#newcode144
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java:144:
} catch (Exception e) {
Another bug fix, not described in the JIRA bug: During runtime it is possible
for RuntimeExceptions to be thrown. The old code only caught checked exceptions.
The RuntimeExceptions causes the loop above to throw a "Processing interrupted"
exception rather than simply place the error in the Json metadata, which caused
the entire metadata request to fail because of a single gadget. This catch will
prevent that.
Issue 183130: [SHINDIG-1257] Allow extensions to JsonRpcHandler, plus bug fixes
Created 14 years, 4 months ago by Jon Weygandt
Modified 9 years, 4 months ago
Reviewers: shindig.remailer_gmail.com
Base URL: http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Comments: 1