Issue 183084: code review 183084: test case for issue 471

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183084: code review 183084: test case for issue 471 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by gri

Modified:
15 years, 8 months ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

test case for issue 471

Patch Set 1 #

Patch Set 2 : code review 183084: test case for issue 471 #

Patch Set 3 : code review 183084: test case for issue 471 #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	A	test/bugs/bug238.go	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
	M	test/golden.out	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 8 months ago (2009-12-29 20:06:11 UTC) #1

iant

Each ERROR line should have a string to match the error, e.g., // ERROR "wrong|incompatible"

15 years, 8 months ago (2009-12-29 21:32:09 UTC) #2

gri

PTAL On Tue, Dec 29, 2009 at 1:32 PM, <iant@golang.org> wrote: > Each ERROR line ...

15 years, 8 months ago (2009-12-29 21:38:48 UTC) #3

gri

15 years, 8 months ago (2009-12-29 22:01:12 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d2402f4513f2 ***

test case for issue 471

R=iant
CC=golang-dev
http://codereview.appspot.com/183084

Expand All Messages | Collapse All Messages