Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(619)

Issue 183075: code review 183075: add a debugging printer to the gob package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by r
Modified:
15 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

add a debugging printer to the gob package. used only for debugging, debug.go is not normally part of the package source. also add a dump program to call it.

Patch Set 1 #

Patch Set 2 : code review 183075: add a debugging printer to the gob package. #

Patch Set 3 : code review 183075: add a debugging printer to the gob package. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -0 lines) Patch
M src/pkg/gob/Makefile View 1 chunk +8 lines, -0 lines 0 comments Download
A src/pkg/gob/debug.go View 1 1 chunk +216 lines, -0 lines 0 comments Download
A src/pkg/gob/dump.go View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 5 months ago (2009-12-29 01:54:30 UTC) #1
rsc
LGTM
15 years, 5 months ago (2009-12-29 02:59:19 UTC) #2
r
15 years, 5 months ago (2009-12-29 03:03:37 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=4dc01baf7acc ***

add a debugging printer to the gob package.
used only for debugging, debug.go is not normally part of the package source.

also add a dump program to call it.

R=rsc
CC=golang-dev
http://codereview.appspot.com/183075
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b