code review 183065: Improved Xcode support

Improved Xcode support

Added definition for raw string.
Added definitions for function and method declarations.
Enabled function, method, and type declarations to appear in Editor pop up menu.
Fixes Issue 466.

[KenF, 2009-12-26 17:30:13]

Hello golang-dev@googlegroups.com (cc: KenF, golang-dev@googlegroups.com),

I'd like you to review the following change.

[KenF, 2009-12-28 07:56:18]

Adding "." to identifier Chars has the side-effect of extending double click
selections to all of a qualified identifier, rather than just one part. This
makes editing more difficult. It would be better to undo this.

There are still some function return types (slices and pointers) which are not
being picked up.

It would be better to define a return expression and qualified identifier.

Grouped types are not being picked up. (keyword at least)

Could add const and var declarations to pop up menu.

[gri, 2009-12-28 21:23:32]

Please fix the minor formatting issue. Also, you will need to fill out
theindividual contributor license agreement (see
http://golang.org/doc/contribute.html#copyright ) so that we can accept your
contribution.

Thanks,
- gri

http://codereview.appspot.com/183065/diff/1002/3
File misc/xcode/go.xclangspec (right):

http://codereview.appspot.com/183065/diff/1002/3#newcode87
misc/xcode/go.xclangspec:87: {
please use tabs for indentation for uniformity

[KenF, 2009-12-29 08:48:44]

I've submitted the individual contributor license agreement.
There is a new version uploaded...

I've updated the format with tabs.
I've removed the "." from identifier characters, as this degraded selection
while editing.
I've removed the attempts to pick the return clause. I could not get it work
correctly.
I decided not to try and include var and const declarations in the pop up menu.
I could not find any examples of this for other languages.
I added rawstring at the toplevel.
I changed the Type of xcode.lang.go.function.declaration to be
xcode.syntax.declaration.function, for consistency with methods. What Go calls
"declarations" other languages call definitions (using declaration for the
header file prototype). But I decided to stick with the Go Language Spec
terminology...

Ken

On 2009/12/28 21:23:32, gri wrote:
> Please fix the minor formatting issue. Also, you will need to fill out
> theindividual contributor license agreement (see
> http://golang.org/doc/contribute.html#copyright ) so that we can accept your
> contribution.
> 
> Thanks,
> - gri
> 
> http://codereview.appspot.com/183065/diff/1002/3
> File misc/xcode/go.xclangspec (right):
> 
> http://codereview.appspot.com/183065/diff/1002/3#newcode87
> misc/xcode/go.xclangspec:87: {
> please use tabs for indentation for uniformity

[gri, 2009-12-29 22:33:04]

LGTM.

FYI. I have removed the escape char from the raw string definition as there
is no escape for these strings (
http://golang.org/doc/go_spec.html#String_literals ).

Thanks for your contribution! (I'm an Xcode user myself)
- gri

On Tue, Dec 29, 2009 at 12:48 AM, <kenliz@cruzio.com> wrote:

> I've submitted the individual contributor license agreement.
> There is a new version uploaded...
>
> I've updated the format with tabs.
> I've removed the "." from identifier characters, as this degraded
> selection while editing.
> I've removed the attempts to pick the return clause. I could not get it
> work correctly.
> I decided not to try and include var and const declarations in the pop
> up menu. I could not find any examples of this for other languages.
> I added rawstring at the toplevel.
> I changed the Type of xcode.lang.go.function.declaration to be
> xcode.syntax.declaration.function, for consistency with methods. What Go
> calls "declarations" other languages call definitions (using declaration
> for the header file prototype). But I decided to stick with the Go
> Language Spec terminology...
>
> Ken
>
>
> On 2009/12/28 21:23:32, gri wrote:
>
>> Please fix the minor formatting issue. Also, you will need to fill out
>> theindividual contributor license agreement (see
>> http://golang.org/doc/contribute.html#copyright ) so that we can
>>
> accept your
>
>> contribution.
>>
>
>  Thanks,
>> - gri
>>
>
>  http://codereview.appspot.com/183065/diff/1002/3
>> File misc/xcode/go.xclangspec (right):
>>
>
>  http://codereview.appspot.com/183065/diff/1002/3#newcode87
>> misc/xcode/go.xclangspec:87: {
>> please use tabs for indentation for uniformity
>>
>
>
>
> http://codereview.appspot.com/183065
>

[gri, 2009-12-29 22:43:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=30b0c3921326 ***

Improved Xcode support

Added definition for raw string.
Added definitions for function and method declarations.
Enabled function, method, and type declarations to appear in Editor pop up menu.
Fixes Issue 466.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/183065

Committer: Robert Griesemer <gri@golang.org>