Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(714)

Issue 183049: code review 183049: Use t.Errorf for formatted error output. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by iant
Modified:
15 years, 6 months ago
Reviewers:
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

Use t.Errorf for formatted error output.

Patch Set 1 #

Patch Set 2 : code review 183049: Use t.Errorf for formatted error output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/signal/signal_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
iant
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 6 months ago (2009-12-24 01:49:49 UTC) #1
r2
LGTM On 24/12/2009, at 12:49 PM, iant@golang.org wrote: > Reviewers: dsymonds1, > > Message: > ...
15 years, 6 months ago (2009-12-24 01:52:26 UTC) #2
dsymonds
LGTM Oops.
15 years, 6 months ago (2009-12-24 01:55:00 UTC) #3
iant
15 years, 6 months ago (2009-12-24 06:08:54 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=affe0f093696 ***

Use t.Errorf for formatted error output.

R=dsymonds1
CC=golang-dev
http://codereview.appspot.com/183049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b