code review 181155: godoc: serve index.html in place of directory listing, ...

godoc: serve index.html in place of directory listing, when present

[rsc, 2010-01-06 23:46:20]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[gri, 2010-01-06 23:55:42]

LGTM

On Wed, Jan 6, 2010 at 3:46 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> godoc: serve index.html in place of directory listing, when present
>
> Please review this at http://codereview.appspot.com/181155
>
> Affected files:
>  M src/cmd/godoc/godoc.go
>
>
> Index: src/cmd/godoc/godoc.go
> ===================================================================
> --- a/src/cmd/godoc/godoc.go
> +++ b/src/cmd/godoc/godoc.go
> @@ -943,6 +943,12 @@
>                return
>
>        case ext == ".html":
> +               if strings.HasSuffix(path, "/index.html") {
> +                       // We'll show index.html for the directory.
> +                       // Use the dir/ version as canonical instead of
> dir/index.html.
> +                       http.Redirect(c,
> r.URL.Path[0:len(r.URL.Path)-len("index.html")],
> http.StatusMovedPermanently)
> +                       return
> +               }
>                serveHTMLDoc(c, r, path)
>                return
>
> @@ -958,6 +964,10 @@
>        }
>
>        if dir != nil && dir.IsDirectory() {
> +               if index := path + "/index.html"; isTextFile(index) {
> +                       serveHTMLDoc(c, r, index)
> +                       return
> +               }
>                serveDirectory(c, r, path)
>                return
>        }
>
>
>

[rsc, 2010-01-06 23:59:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=d7b864a710ab ***

godoc: serve index.html in place of directory listing, when present

R=gri
CC=golang-dev
http://codereview.appspot.com/181155