Issue 181111: code review 181111: Remove redundant size check in resize. Let callers worr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181111: code review 181111: Remove redundant size check in resize. Let callers worr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by i3d

Modified:
15 years, 6 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

Remove redundant size check in resize. Let callers worry about that and resize should just do "resize".

Patch Set 1 #

Patch Set 2 : code review 181111: Remove redundant size check in resize. Let callers worr... #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	src/pkg/bytes/buffer.go	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

i3d

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 6 months ago (2010-01-01 23:49:23 UTC) #1

15 years, 6 months ago (2010-01-02 00:09:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e4556758b827 ***

Remove redundant size check in resize. Let callers worry about that and resize
should just do "resize".

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/181111

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages