code review 181102: Use -fno-eliminate-unused-debug-types when calling gcc ...

cgo: Use -fno-eliminate-unused-debug-types when calling gcc to for dwarf stabs.

This keeps debug symbols in for e.g. unreferenced enums.

Fixes issue 479

[dho, 2009-12-30 05:26:01]

Hello rsc (cc: golang-dev@googlegroups.com, waltermundt),

I'd like you to review the following change.

[rsc, 2010-01-03 01:06:19]

Please check when this flag was added.
I.e. what version of gcc will be required if
we make this change?

[iant2, 2010-01-03 05:02:09]

Russ Cox <rsc@golang.org> writes:

> Please check when this flag was added.
> I.e. what version of gcc will be required if
> we make this change?

The -fno-eliminate-unused-debug-types option was added in gcc 3.4.

Ian

[rsc, 2010-01-05 22:15:14]

LGTM, thanks

Before I apply it, please tweak the issue message:

1. insert "cgo: " at the beginning of the first line.
2. drop the # in "Fixes issue #479".  It probably doesn't
matter but if we use the same syntax then they're 
easy to find with hg log -v | grep

[dho, 2010-01-05 22:18:42]

On 2010/01/05 22:15:14, rsc wrote:
> LGTM, thanks

np!
 
> Before I apply it, please tweak the issue message:
> 
> 1. insert "cgo: " at the beginning of the first line.
> 2. drop the # in "Fixes issue #479".  It probably doesn't
> matter but if we use the same syntax then they're 
> easy to find with hg log -v | grep

Alright; done. PTAL :)

[rsc, 2010-01-05 22:54:47]

> Alright; done. PTAL :)

i don't see it when i look at
http://codereview.appspot.com/181102/show

[dho, 2010-01-05 22:56:04]

On 2010/01/05 22:54:47, rsc wrote:
> > Alright; done. PTAL :)
> 
> i don't see it when i look at
> http://codereview.appspot.com/181102/show

That's weird. I ran hg change 181102 and ran hg upload as well. I'll try editing
the issue via the web interface, I guess.

[dho, 2010-01-06 16:17:31]

PTAL

[rsc, 2010-01-06 23:45:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=c457d53acb90 ***

cgo: Use -fno-eliminate-unused-debug-types when calling gcc to for dwarf stabs.

This keeps debug symbols in for e.g. unreferenced enums.

Fixes issue 479

R=rsc
CC=golang-dev, waltermundt
http://codereview.appspot.com/181102

Committer: Russ Cox <rsc@golang.org>