code review 181085: Fix bug in godoc tab conversion filter:

Fix bug in godoc tab conversion filter:
tabs after an empty line where not converted.

Also, made it more robust in the presence of
(unexpected) ' ' and '\v' chars in indentation
mode.

[gri, 2009-12-29 00:30:53]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[r2, 2009-12-29 01:23:09]

LGTM

On 29/12/2009, at 11:30 AM, gri@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> Fix bug in godoc tab conversion filter:
> tabs after an empty line where not converted.
>
> Also, made it more robust in the presence of
> (unexpected) ' ' and '\v' chars in indentation
> mode.
>
> Please review this at http://codereview.appspot.com/181085
>
> Affected files:
>  M src/cmd/godoc/godoc.go
>
>
> Index: src/cmd/godoc/godoc.go
> ===================================================================
> --- a/src/cmd/godoc/godoc.go
> +++ b/src/cmd/godoc/godoc.go
> @@ -471,8 +471,8 @@
> }
>
>
> -func (p *tconv) writeIndent(n int) (err os.Error) {
> -	i := n * *tabwidth
> +func (p *tconv) writeIndent() (err os.Error) {
> +	i := p.indent
> 	for i > len(spaces) {
> 		i -= len(spaces)
> 		if _, err = p.output.Write(spaces); err != nil {
> @@ -490,12 +490,20 @@
> 	for n, b = range data {
> 		switch p.state {
> 		case indenting:
> -			if b == '\t' {
> +			switch b {
> +			case '\t', '\v':
> +				p.indent += *tabwidth
> +			case '\n':
> +				p.indent = 0
> +				if _, err = p.output.Write(data[n : n+1]); err != nil {
> +					return
> +				}
> +			case ' ':
> 				p.indent++
> -			} else {
> +			default:
> 				p.state = collecting
> 				pos = n
> -				if err = p.writeIndent(p.indent); err != nil {
> +				if err = p.writeIndent(); err != nil {
> 					return
> 				}
> 			}
>
>

[gri, 2009-12-29 01:24:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=f2338b67860d ***

Fix bug in godoc tab conversion filter:
tabs after an empty line where not converted.

Also, made it more robust in the presence of
(unexpected) ' ' and '\v' chars in indentation
mode.

R=r
CC=golang-dev
http://codereview.appspot.com/181085