Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 181084: code review 181084: A couple of tighter loops. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by gri
Modified:
15 years, 6 months ago
Reviewers:
CC:
agl, agl1, golang-dev
Visibility:
Public.

Description

A couple of tighter loops. (I was looking at this code accidentally because of some gofmt issues and thought that one could write this more effectively. You may have deliberately chosen not to use ranges here to make the index range clearer. Just let me know.)

Patch Set 1 #

Patch Set 2 : code review 181084: A couple of tighter loops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/pkg/crypto/md5/md5.go View 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 4
gri
Hello agl (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 6 months ago (2009-12-28 23:40:10 UTC) #1
agl1
LGTM. (I didn't write this code however.)
15 years, 6 months ago (2009-12-28 23:43:28 UTC) #2
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=fc2dc436e8ea *** A couple of tighter loops. (I was looking at this ...
15 years, 6 months ago (2009-12-28 23:49:00 UTC) #3
rsc
15 years, 6 months ago (2009-12-29 03:01:12 UTC) #4
The same changes can be made in sha1 and sha256.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b