Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(404)

Issue 181083: code review 181083: Clarify section on tokens. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by gri
Modified:
15 years, 4 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

Clarify section on tokens. Fixes issue 457.

Patch Set 1 #

Patch Set 2 : code review 181083: Clarify section on tokens. #

Total comments: 1

Patch Set 3 : code review 181083: Clarify section on tokens. #

Patch Set 4 : code review 181083: Clarify section on tokens. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M doc/go_spec.html View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 4 months ago (2009-12-28 22:14:30 UTC) #1
r
LGTM http://codereview.appspot.com/181083/diff/1002/1003 File doc/go_spec.html (right): http://codereview.appspot.com/181083/diff/1002/1003#newcode159 doc/go_spec.html:159: that would otherwise combine into a single token ...
15 years, 4 months ago (2009-12-28 22:19:59 UTC) #2
gri
PTAL. Dont' I need a comma after "single token" ? On Mon, Dec 28, 2009 ...
15 years, 4 months ago (2009-12-28 22:29:04 UTC) #3
r2
On 29/12/2009, at 9:28 AM, Robert Griesemer wrote: > PTAL. > > Dont' I need ...
15 years, 4 months ago (2009-12-28 22:35:27 UTC) #4
gri
15 years, 4 months ago (2009-12-28 22:40:44 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f26ee0960887 ***

Clarify section on tokens.
Fixes issue 457.

R=r
CC=golang-dev
http://codereview.appspot.com/181083
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b