Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(312)

Issue 181063: code review 181063: net: Initial (rough) /etc/hosts parsing + lookup support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by cw
Modified:
15 years, 6 months ago
Reviewers:
CC:
golang-dev, rsc, r, dho, nictuku
Visibility:
Public.

Description

net: Initial (rough) /etc/hosts parsing + lookup support.

Patch Set 1 #

Patch Set 2 : code review 181063: net: Initial (rough) /etc/hosts parsing + lookup support. #

Patch Set 3 : code review 181063: net: Initial (rough) /etc/hosts parsing + lookup support. #

Patch Set 4 : code review 181063: net: Initial (rough) /etc/hosts parsing + lookup support. #

Patch Set 5 : code review 181063: net: Initial (rough) /etc/hosts parsing + lookup support. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/pkg/net/dnsclient.go View 1 2 3 4 chunks +36 lines, -3 lines 3 comments Download

Messages

Total messages: 14
cw
Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 7 months ago (2009-12-25 08:11:59 UTC) #1
cw
Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 7 months ago (2009-12-25 18:04:30 UTC) #2
rsc
+krasin On Dec 25, 2009 1:04 PM, <cw@f00f.org> wrote: Hello rsc, r (cc: golang-dev@googlegroups.com), I'd ...
15 years, 7 months ago (2009-12-26 14:25:55 UTC) #3
dho
On 2009/12/26 14:25:55, rsc wrote: > +krasin > > On Dec 25, 2009 1:04 PM, ...
15 years, 7 months ago (2009-12-26 16:50:42 UTC) #4
cw
On Sat, Dec 26, 2009 at 04:50:42PM +0000, devon.odell@gmail.com wrote: > Only thing about this ...
15 years, 7 months ago (2009-12-26 18:16:11 UTC) #5
cw
[Sorry this is a bit long-winded and probably full of errors] Looking at this a ...
15 years, 7 months ago (2009-12-26 19:34:35 UTC) #6
nictuku
A few comments. By the way, as I mentioned in the issue #313, I'm writing ...
15 years, 7 months ago (2009-12-27 04:13:08 UTC) #7
cw
On Sun, Dec 27, 2009 at 04:13:08AM +0000, yves.junqueira@gmail.com wrote: > Properly capitalize and add ...
15 years, 7 months ago (2009-12-27 04:43:31 UTC) #8
dho
2009/12/26 <cw@f00f.org>: > [Sorry this is a bit long-winded and probably full of errors] > ...
15 years, 7 months ago (2009-12-27 15:58:15 UTC) #9
dho
2009/12/26 Chris Wedgwood <cw@f00f.org>: > On Sun, Dec 27, 2009 at 04:13:08AM +0000, yves.junqueira@gmail.com wrote: ...
15 years, 7 months ago (2009-12-27 15:58:56 UTC) #10
rsc
> If dns was moved out of pkg/net, that would be ok, in my opinion. ...
15 years, 7 months ago (2010-01-05 22:53:46 UTC) #11
dho
On 2010/01/05 22:53:46, rsc wrote: > > If dns was moved out of pkg/net, that ...
15 years, 7 months ago (2010-01-06 16:20:31 UTC) #12
rsc
15 years, 7 months ago (2010-01-07 17:46:38 UTC) #13
cw
15 years, 6 months ago (2010-01-16 23:05:22 UTC) #14
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b