Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 181055: code review 181055: fix naked < and > as reported by Peter Williams <> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 3 months ago by r
Modified:
16 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev, pwil3058
Visibility:
Public.

Description

fix naked < and > as reported by Peter Williams <> (i thought these were legal in <pre> blocks)

Patch Set 1 #

Patch Set 2 : code review 181055: fix naked < and > as reported by Peter Williams <> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M doc/effective_go.html View 1 25 chunks +40 lines, -40 lines 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: golang-dev@googlegroups.com, pwil3058@gmail.com), I'd like you to review the following change.
16 years, 3 months ago (2009-12-24 08:36:28 UTC) #1
rsc
LGTM
16 years, 3 months ago (2009-12-24 20:09:27 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=0ba4f3f4f651 *** fix naked < and > as reported by Peter Williams ...
16 years, 3 months ago (2009-12-24 20:13:21 UTC) #3
pwil3058
16 years, 3 months ago (2009-12-24 22:14:41 UTC) #4
On 24/12/09 18:36, r@golang.org wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com, pwil3058@gmail.com),
>
> I'd like you to review the following change.
>
>
> Description:
> fix naked < and > as reported by Peter Williams <>
> (i thought these were legal in <pre> blocks)

That seems to be the case in some circumstances (e.g. Firefox seems to 
cope) but where I experienced problems was using calibre (or Amazon's 
kindlegen program) to convert the html to mobi so that I could load them 
onto my kindle (and read them down at the coffee shop or while watching 
TV).  I'm using mobi instead of pdf as the pdf image's text is too small 
for convenient reading on the standard (not DX) kindle.

I also have to wrap the files in a couple of lines of extra html code so 
that they satisfy the "structured html" definition which is required for 
conversion to mobi.  I can send you patches for this as well, if you 
want?  As far as I can tell this doesn't effect their use as web pages.

Peter

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b