Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 181050: code review 181050: Add a test for issue 337. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by iant
Modified:
15 years, 6 months ago
Reviewers:
nictuku
CC:
rsc, golang-dev
Visibility:
Public.

Description

Add a test for issue 337. gccgo currently miscompiles this test.

Patch Set 1 #

Patch Set 2 : code review 181050: Add a test for issue 337. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A test/fixedbugs/bug237.go View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 6 months ago (2009-12-24 01:47:46 UTC) #1
r2
LGTM On 24/12/2009, at 12:47 PM, iant@golang.org wrote: > Reviewers: rsc, > > Message: > ...
15 years, 6 months ago (2009-12-24 01:52:14 UTC) #2
iant
*** Submitted as http://code.google.com/p/go/source/detail?r=dcf719ee703b *** Add a test for issue 337. gccgo currently miscompiles this ...
15 years, 6 months ago (2009-12-24 06:08:36 UTC) #3
nictuku
FYI The filed was named bug237.go but should be bug337.go.
15 years, 6 months ago (2009-12-28 01:30:36 UTC) #4
r2
15 years, 6 months ago (2009-12-28 08:19:04 UTC) #5
On 28/12/2009, at 12:30 PM, yves.junqueira@gmail.com wrote:

> FYI
>
> The filed was named bug237.go but should be bug337.go.
>
> http://codereview.appspot.com/181050

No. The similarity is a coincidence.  The bug tests are numbered  
sequentially, and this is the 237th recorded.

-rob

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b