Issue 180073: [PATCH] Fix a memory leak in OpaqueType

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180073: [PATCH] Fix a memory leak in OpaqueType (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by collinwinter

Modified:
15 years, 1 month ago

Reviewers:

CC:
Jeffrey Yasskin (google), llvm-commits_cs.uiuc.edu

Base URL:
http://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Description

This fixes a memory leak found by Google's internal heapchecker. LLVM, Clang and Unladen Swallow tests pass. Committed as http://llvm.org/viewvc/llvm-project?view=rev&revision=91611.

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -3 lines)			Patch
M	include/llvm/DerivedTypes.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	lib/VMCore/LLVMContextImpl.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	lib/VMCore/Type.cpp	View	2 chunks	+17 lines, -0 lines	0 comments	Download
A	unittests/VMCore/DerivedTypesTest.cpp	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

clattner_apple.com

15 years, 1 month ago (2009-12-17 19:25:47 UTC) #2

On Dec 16, 2009, at 3:48 PM, collinwinter@google.com wrote:

> Reviewers: ,
> 
> Message:
> Please take a look.
> 
> Description:
> This fixes a memory leak found by Google's internal heapchecker.
> LLVM/Clang tests pass.
> 
> Please review this at http://codereview.appspot.com/180073

Looks great to me, please apply.  Nice catch!

-Chris

Expand All Messages | Collapse All Messages