"Enabling -Wshadow option"

[Preston Jackson, 2009-12-15 18:34:50]

Adding support for the -Wshadow GCC compiler flag. Issue 220.

[wan, 2009-12-15 19:41:03]

Sorry for suggesting a massive change.  I can do it myself if you don't have
time.  Thanks!

http://codereview.appspot.com/180041/diff/18/24
File include/gtest/gtest-test-part.h (right):

http://codereview.appspot.com/180041/diff/18/24#newcode59
include/gtest/gtest-test-part.h:59: TestPartResult(Type outcome_type,
The convention I like is to call this a_type (and a_file_name, a_line_number,
etc for others).  Then it's easy to match up the parameter with the field.  And
you don't have to think hard for good names when new parameters are added.

[Preston Jackson, 2009-12-16 18:13:35]

Ok, changed to an "a_" prefix.

Do you want me to use "an_" in appropriate places? (I did)

Do you want me to change _all_ parameters in a method/function signature to use
"a_"? (I didn't)

[wan, 2009-12-16 18:15:55]

On Wed, Dec 16, 2009 at 10:13 AM,  <preston.a.jackson@gmail.com> wrote:
> Ok, changed to an "a_" prefix.

Great.  Thanks for doing the grungy work!

> Do you want me to use "an_" in appropriate places? (I did)

Yes, this is greawt.

> Do you want me to change _all_ parameters in a method/function signature
> to use "a_"? (I didn't)

No need for that.  We just need to fix where the warnings are.

> http://codereview.appspot.com/180041
>



-- 
Zhanyong

[wan, 2009-12-16 18:21:23]

I've looked through the entire change.  Everything's great!  Thanks
for the hard work.  I'll get this tested and checked in soon.

2009/12/16 Zhanyong Wan (λx.x x) <wan@google.com>:
> On Wed, Dec 16, 2009 at 10:13 AM,  <preston.a.jackson@gmail.com> wrote:
>> Ok, changed to an "a_" prefix.
>
> Great.  Thanks for doing the grungy work!
>
>> Do you want me to use "an_" in appropriate places? (I did)
>
> Yes, this is greawt.
>
>> Do you want me to change _all_ parameters in a method/function signature
>> to use "a_"? (I didn't)
>
> No need for that.  We just need to fix where the warnings are.
>
>> http://codereview.appspot.com/180041
>>
>
>
>
> --
> Zhanyong
>



-- 
Zhanyong