Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8228)

Issue 179121: Doc -- Add info on \version statements to Tutorial (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Carl
Modified:
14 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc -- Add info on \version statements to Tutorial

Patch Set 1 #

Patch Set 2 : Fixed typos in earlier patch #

Total comments: 8

Patch Set 3 : Respond to Graham's comments #

Patch Set 4 : Respond to Mark's comments #

Patch Set 5 : Fix editing typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -50 lines) Patch
M Documentation/learning/common-notation.itely View 2 chunks +0 lines, -33 lines 0 comments Download
M Documentation/learning/tutorial.itely View 1 2 3 4 12 chunks +46 lines, -17 lines 0 comments Download

Messages

Total messages: 5
Graham Percival (old account)
ok, given the support for this idea, I'm ok with in theory. Comments below. http://codereview.appspot.com/179121/diff/1002/3 ...
14 years, 4 months ago (2009-12-22 15:14:01 UTC) #1
Mark Polesky
http://codereview.appspot.com/179121/diff/1002/3 File Documentation/learning/tutorial.itely (right): http://codereview.appspot.com/179121/diff/1002/3#newcode51 Documentation/learning/tutorial.itely:51: but don't forget the @w{}: \version @w{"@version{}"} http://codereview.appspot.com/179121/diff/1002/3#newcode296 Documentation/learning/tutorial.itely:296: ...
14 years, 4 months ago (2009-12-22 15:57:03 UTC) #2
Mark Polesky
http://codereview.appspot.com/179121/diff/1002/3 File Documentation/learning/tutorial.itely (right): http://codereview.appspot.com/179121/diff/1002/3#newcode315 Documentation/learning/tutorial.itely:315: lilypond test.ly Also, remove command input; and update output ...
14 years, 4 months ago (2009-12-22 16:05:19 UTC) #3
c_sorensen
On 12/22/09 8:14 AM, "percival.music.ca@gmail.com" <percival.music.ca@gmail.com> wrote: > ok, given the support for this idea, ...
14 years, 4 months ago (2009-12-22 22:00:13 UTC) #4
Graham Percival
14 years, 4 months ago (2009-12-23 00:51:30 UTC) #5
On Tue, Dec 22, 2009 at 02:57:26PM -0700, Carl Sorensen wrote:
> 
> All the changes have been made.  A new version is pushed:
> 
> http://codereview.appspot.com/179121

Looks fine; please push.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b