code review 1777041: minor error checking to android launcher

minor error checking to android launcher

[kaib, 2010-07-09 12:06:54]

Hello devon.odell@gmail.com, dho (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-07-12 21:34:59]

> -if [ $rsize != $rcheck ] ; then
> +if [ -z $rsize ] || [ $rsize != $rcheck ] ; then

Only fixes it because test ([) is too clever by half.  You want

if [ "$rsize" != "$rcheck" ]; then

[kaib, 2010-07-19 08:42:49]

done

On 2010/07/12 21:34:59, rsc wrote:
> > -if [ $rsize != $rcheck ] ; then
> > +if [ -z $rsize ] || [ $rsize != $rcheck ] ; then
> 
> Only fixes it because test ([) is too clever by half.  You want
> 
> if [ "$rsize" != "$rcheck" ]; then
>

[kaib, 2010-07-19 08:44:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=f3f517cb8c66 ***

minor error checking to android launcher

R=dho
CC=golang-dev
http://codereview.appspot.com/1777041

[rsc, 2010-07-21 06:47:11]

LGTM