code review 175046: - parser changed to reflect new semicolon rules

- parser changed to reflect new semicolon rules
- this CL is pending the updated scanner (CL forthcoming)
- will submit only after new scanner has been checked in
  and an updated version of gofmt can choose between the
  new and old exp/parser

[gri, 2009-12-10 22:37:18]

Hello rsc,

I'd like you to review the following change.

[gri, 2009-12-11 18:47:45]

PTAL. Now handles labels correctly.
- Robert

On Thu, Dec 10, 2009 at 2:37 PM, <gri@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc,
>
> I'd like you to review the following change.
>
>
> Description:
> - parser changed to reflect new semicolon rules
> - this CL is pending the updated scanner (CL forthcoming)
> - will submit only after new scanner has been checked in
>  and an updated version of gofmt can choose between the
>  new and old exp/parser
>
> Please review this at http://codereview.appspot.com/175046
>
> Affected files:
>  M src/pkg/go/parser/parser.go
>  M src/pkg/go/parser/parser_test.go
>
>
>

[rsc, 2009-12-11 18:56:53]

LGTM

(but wait for the new printer)

http://codereview.appspot.com/175046/diff/2005/2006
File src/pkg/go/parser/parser.go (right):

http://codereview.appspot.com/175046/diff/2005/2006#newcode965
src/pkg/go/parser/parser.go:965: if p.tok == token.COMMA {
can invert to simplify and avoid the else

if p.tok != token.COMMA {
    break
}
p.next()

http://codereview.appspot.com/175046/diff/2005/2006#newcode1287
src/pkg/go/parser/parser.go:1287: p.expectSemi();	// TODO(gri) do this better
can factor out the expectSemi (move up above the if, delete below).  not sure if
that's better.

http://codereview.appspot.com/175046/diff/2005/2006#newcode1304
src/pkg/go/parser/parser.go:1304: p.expectSemi();	// TODO(gri) do this better
same comment

[gri, 2009-12-11 23:31:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=eb649506b832 ***

parser changed to reflect new semicolon rules

R=rsc
http://codereview.appspot.com/175046

Committer: Robert Griesemer <gri@golang.org>

[rsc, 2009-12-13 20:40:55]

Another that failed to auto-close.