Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(650)

Issue 1744041: code review 1744041: Avoid duplicate generation of enum code when the enum ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by dsymonds
Modified:
15 years, 1 month ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

Avoid duplicate generation of enum code when the enum is inside a nested message. Fixes issue 2.

Patch Set 1 #

Patch Set 2 : code review 1744041: Avoid duplicate generation of enum code when the enum ... #

Patch Set 3 : code review 1744041: Avoid duplicate generation of enum code when the enum ... #

Patch Set 4 : code review 1744041: Avoid duplicate generation of enum code when the enum ... #

Patch Set 5 : code review 1744041: Avoid duplicate generation of enum code when the enum ... #

Patch Set 6 : code review 1744041: Avoid duplicate generation of enum code when the enum ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M compiler/generator/generator.go View 1 chunk +5 lines, -12 lines 0 comments Download
M compiler/testdata/test.proto View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/testdata/test.pb.go.golden View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 1 month ago (2010-06-26 07:38:32 UTC) #1
r
LGTM
15 years, 1 month ago (2010-06-27 00:15:59 UTC) #2
dsymonds
15 years, 1 month ago (2010-06-27 00:33:56 UTC) #3
*** Submitted as e6691044acd1 ***

	Avoid duplicate generation of enum code when the enum is inside a nested
message.
        Fixes issue 2.

R=r
CC=golang-dev
http://codereview.appspot.com/1744041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b