code review 174050: implement NoSemis and NoStringConcat mode for go/printer

implement NoSemis and NoStringConcat mode for go/printer

[gri, 2009-12-10 23:21:32]

Hello rsc,

I'd like you to review the following change.

[rsc, 2009-12-10 23:36:10]

LGTM

http://codereview.appspot.com/174050/diff/1/2
File src/pkg/go/printer/nodes.go (right):

http://codereview.appspot.com/174050/diff/1/2#newcode143
src/pkg/go/printer/nodes.go:143: addSep;				// elements are separared by add
operators
I suggest calling this plusSep; add sounds like a verb rather than a punctuation
character, and addition operators is too verbose.

http://codereview.appspot.com/174050/diff/1/3
File src/pkg/go/printer/printer.go (right):

http://codereview.appspot.com/174050/diff/1/3#newcode897
src/pkg/go/printer/printer.go:897: NoSemis;		// don't print semicolons at the
end of a line
These end up creating a lot of double-negatives.
Is the plan that when the default changes, the names
would change too?  (It seems like the default must be 0,
there's no other choice.)

[gri, 2009-12-10 23:45:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=ea280f90e7b4 ***

implement NoSemis and NoStringConcat mode for go/printer

R=rsc
http://codereview.appspot.com/174050